add dependencies for ros2 SSC #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
MishkaMN
requested changes
Oct 31, 2024
noetic-foxy/Dockerfile
Outdated
Comment on lines
199
to
202
| sh -c 'echo "deb [trusted=yes] https://s3.amazonaws.com/autonomoustuff-repo/ $(lsb_release -sc) main" > /etc/apt/sources.list.d/autonomoustuff-public.list' && \ | ||
| apt-get update && \ | ||
| apt-get install --no-install-recommends --yes libas-common && \ | ||
| # ROS2 SSC dependencies from Astuff | ||
| apt-get install ros-foxy-pacmod3-msgs --yes && \ |
There was a problem hiding this comment.
I think this is failing because the source list from autonomous stuff need to be first?
Also that makes me think why it didn't work the first time because the message dependency is here?
There was a problem hiding this comment.
Yes that is correct, this package is from Astuff distribution
MishkaMN
added
bug
MishkaMN
approved these changes
Nov 1, 2024
MishkaMN
pushed a commit
to usdot-fhwa-stol/carma-ssc-interface-wrapper
that referenced
this pull request
Nov 1, 2024
<!-- Thanks for the contribution, this is awesome. --> # PR Details Updating image to not install pacmod3_msgs since they are being installed in carma-base under usdot-fhwa-stol/carma-base#208 ## Description <!--- Describe your changes in detail --> Removes installation for pacmod3_msgs and apt-transport-s3 packages which ## Related GitHub Issue <!--- This project only accepts pull requests related to open GitHub issues or Jira Keys --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please DO NOT name partially fixed issues, instead open an issue specific to this fix --> <!--- Please link to the issue here: --> ## Related Jira Key <!-- e.g. CAR-123 --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Defect fix (non-breaking change that fixes an issue) - [x] New feature (non-breaking change that adds functionality) - [ ] Breaking change (fix or feature that cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] I have added any new packages to the sonar-scanner.properties file - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have read the [**CONTRIBUTING**](https://github.com/usdot-fhwa-stol/carma-platform/blob/develop/Contributing.md) document. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
In order to support ros2 foxy SSC implementation the CARMA system needs to install pacmod3_msgs. This message is currently only installed in the ssc_interface_wrapper. Since rosbags are recorded in the carma-platform container, these messages are also required to be installed there so that the control related topics can be recorded to the rosbag files. In order to avoid duplication of installation across repositories, the packages are installed in carma-base.
Description
Related GitHub Issue
Related Jira Key
https://usdot-carma.atlassian.net/browse/ARC-231
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: